linux-kernel - Re: [RFC PATCH v1] mmc: sdhci-of-arasan: Add the support for sdhci-5.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFrAGd-xDKLK=xAm_L=jgM0t4eQpspngZkwy+B3923BndQ@mail.gmail.com>
Date:	Tue, 25 Aug 2015 14:07:07 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Shawn Lin <shawn.lin@...k-chips.com>
Cc:	Michal Simek <michal.simek@...inx.com>,
	Sören Brinkmann <soren.brinkmann@...inx.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>
Subject: Re: [RFC PATCH v1] mmc: sdhci-of-arasan: Add the support for sdhci-5.1

On 18 August 2015 at 01:40, Shawn Lin <shawn.lin@...k-chips.com> wrote:
> Hi Ulf,
>
>
> On 2015/8/12 13:07, Michal Simek wrote:
>>
>> +linux-mmc
>>
>> On 08/11/2015 04:53 PM, Michal Simek wrote:
>>>
>>> On 08/11/2015 09:46 AM, Shawn Lin wrote:
>>>>
>>>> This patch adds the compatible string in sdhci-of-arasan.c to
>>>> support sdhci-arasan5.1 version of controller. No documented
>>>> controller IP version is found in the TRM, so we use ths version
>>>> of command queueing engine integrated into this controller by arasan
>>>> to specify our controller.
>>>>
>>>> Signed-off-by: Shawn Lin <shawn.lin@...k-chips.com>
>>>>
>>>> ---
>>>>
>>>> Changes in v1:
>>>> - Remove redundant SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN for "arasan,
>>>> sdhci-5.1" since
>>>>    SDHCI will check "host->max_clk == 0" and let driver get it from
>>>> host->ops->get_max_clock.
>>>>
>>>>   Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 2 +-
>>>>   drivers/mmc/host/sdhci-of-arasan.c                     | 1 +
>>>>   2 files changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>>>> b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>>>> index 7e94903..da541c3 100644
>>>> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>>>> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>>>> @@ -9,7 +9,7 @@ Device Tree Bindings for the Arasan SDHCI Controller
>>>>
>>>>   Required Properties:
>>>>     - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' or
>>>> -                'arasan,sdhci-4.9a'
>>>> +                'arasan,sdhci-4.9a' or 'arasan,sdhci-5.1'
>>>>     - reg: From mmc bindings: Register location and length.
>>>>     - clocks: From clock bindings: Handles to clock inputs.
>>>>     - clock-names: From clock bindings: Tuple including "clk_xin" and
>>>> "clk_ahb"
>>>> diff --git a/drivers/mmc/host/sdhci-of-arasan.c
>>>> b/drivers/mmc/host/sdhci-of-arasan.c
>>>> index ef5a7d2..75379cb 100644
>>>> --- a/drivers/mmc/host/sdhci-of-arasan.c
>>>> +++ b/drivers/mmc/host/sdhci-of-arasan.c
>>>> @@ -217,6 +217,7 @@ static int sdhci_arasan_remove(struct
>>>> platform_device *pdev)
>>>>
>>>>   static const struct of_device_id sdhci_arasan_of_match[] = {
>>>>         { .compatible = "arasan,sdhci-8.9a" },
>>>> +       { .compatible = "arasan,sdhci-5.1" },
>>>>         { .compatible = "arasan,sdhci-4.9a" },
>>>>         { }
>>>>   };
>>>>
>>>
>>> Acked-by: Michal Simek <michal.simek@...inx.com>
>
>
> Could you pull this patch into your repository?
>

Thanks, applied for next!

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/