linux-kernel - Re: [PATCH 1/2] efi: Add EFI_MEMORY_MORE_RELIABLE support to efi_md_typeattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Aug 2015 16:23:10 +0200
From:	Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:	Matt Fleming <matt@...eblueprint.co.uk>
Cc:	Taku Izumi <izumi.taku@...fujitsu.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
	"x86@...nel.org" <x86@...nel.org>,
	Matt Fleming <matt.fleming@...el.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>, Tony Luck <tony.luck@...el.com>,
	qiuxishi@...wei.com, kamezawa.hiroyu@...fujitsu.com,
	Laszlo Ersek <lersek@...hat.com>,
	Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH 1/2] efi: Add EFI_MEMORY_MORE_RELIABLE support to efi_md_typeattr_format()

On 25 August 2015 at 16:18, Matt Fleming <matt@...eblueprint.co.uk> wrote:
> On Fri, 21 Aug, at 02:15:52AM, Taku Izumi wrote:
>> UEFI spec 2.5 introduces new Memory Attribute Definition named
>> EFI_MEMORY_MORE_RELIABLE. This patch adds this new attribute
>> support to efi_md_typeattr_format().
>>
>> Signed-off-by: Taku Izumi <izumi.taku@...fujitsu.com>
>> ---
>>  drivers/firmware/efi/efi.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
>> index d6144e3..aadc1c4 100644
>> --- a/drivers/firmware/efi/efi.c
>> +++ b/drivers/firmware/efi/efi.c
>> @@ -589,12 +589,14 @@ char * __init efi_md_typeattr_format(char *buf, size_t size,
>>       attr = md->attribute;
>>       if (attr & ~(EFI_MEMORY_UC | EFI_MEMORY_WC | EFI_MEMORY_WT |
>>                    EFI_MEMORY_WB | EFI_MEMORY_UCE | EFI_MEMORY_WP |
>> -                  EFI_MEMORY_RP | EFI_MEMORY_XP | EFI_MEMORY_RUNTIME))
>> +                  EFI_MEMORY_RP | EFI_MEMORY_XP | EFI_MEMORY_RUNTIME |
>> +                  EFI_MEMORY_MORE_RELIABLE))
>>               snprintf(pos, size, "|attr=0x%016llx]",
>>                        (unsigned long long)attr);
>>       else
>> -             snprintf(pos, size, "|%3s|%2s|%2s|%2s|%3s|%2s|%2s|%2s|%2s]",
>> +             snprintf(pos, size, "|%3s|%4s|%2s|%2s|%2s|%3s|%2s|%2s|%2s|%2s]",
>>                        attr & EFI_MEMORY_RUNTIME ? "RUN" : "",
>> +                      attr & EFI_MEMORY_MORE_RELIABLE ? "RELY" : "",
>>                        attr & EFI_MEMORY_XP      ? "XP"  : "",
>>                        attr & EFI_MEMORY_RP      ? "RP"  : "",
>>                        attr & EFI_MEMORY_WP      ? "WP"  : "",
>
> I'm not keen on using "RELY" because I don't think it's at all obvious
> what it means. "RELI" would be closer, but still could use some
> improvement.
>
> Since we turned off this kernel output by default (at least on x86)
> because the line length had grown quite long, maybe we should just
> embrace it and print "RELIABLE" in full?
>

Since its meaning is not at all obvious even when printing RELIABLE in
full, couldn't we simply use 'MR' instead? You need the UEFI spec to
make sense of this anyway ... (Same goes for RUN btw, perhaps RT would
even be clearer there)

-- 
Ard.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/