linux-kernel - Re: [RFC] arm: change some function and data to init section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.20.1508250800090.21591@knanqh.ubzr>
Date:	Tue, 25 Aug 2015 08:01:32 -0700 (PDT)
From:	Nicolas Pitre <nicolas.pitre@...aro.org>
To:	yalin wang <yalin.wang2010@...il.com>
cc:	linux@....linux.org.uk, catalin.marinas@....com,
	keescook@...omium.org, ard.biesheuvel@...aro.org,
	m.szyprowski@...sung.com, ggdavisiv@...il.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC] arm: change some function and data to init section

On Tue, 25 Aug 2015, yalin wang wrote:

> This patch change some function and the related data to init section,
> they are only called by free_initmem(), can be freed safely after
> boot up.

The magic keyword here is __init_refok.

> Signed-off-by: yalin wang <yalin.wang2010@...il.com>

Acked-by: Nicolas Pitre <nico@...aro.org>


> ---
>  arch/arm/mm/init.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
> index 8a63b4c..7b505de 100644
> --- a/arch/arm/mm/init.c
> +++ b/arch/arm/mm/init.c
> @@ -577,7 +577,7 @@ struct section_perm {
>  	pmdval_t clear;
>  };
>  
> -static struct section_perm nx_perms[] = {
> +static struct section_perm nx_perms[] __initdata = {
>  	/* Make pages tables, etc before _stext RW (set NX). */
>  	{
>  		.start	= PAGE_OFFSET,
> @@ -680,7 +680,7 @@ static inline bool arch_has_strict_perms(void)
>  	}								\
>  }
>  
> -static inline void fix_kernmem_perms(void)
> +static void __init fix_kernmem_perms(void)
>  {
>  	set_section_perms(nx_perms, prot);
>  }
> @@ -706,7 +706,7 @@ void set_kernel_text_ro(void)
>  static inline void fix_kernmem_perms(void) { }
>  #endif /* CONFIG_ARM_KERNMEM_PERMS */
>  
> -void free_tcmmem(void)
> +static void __init free_tcmmem(void)
>  {
>  #ifdef CONFIG_HAVE_TCM
>  	extern char __tcm_start, __tcm_end;
> @@ -716,7 +716,7 @@ void free_tcmmem(void)
>  #endif
>  }
>  
> -void free_initmem(void)
> +void __init_refok free_initmem(void)
>  {
>  	fix_kernmem_perms();
>  	free_tcmmem();
> @@ -728,9 +728,9 @@ void free_initmem(void)
>  
>  #ifdef CONFIG_BLK_DEV_INITRD
>  
> -static int keep_initrd;
> +static int keep_initrd __initdata;
>  
> -void free_initrd_mem(unsigned long start, unsigned long end)
> +void __init free_initrd_mem(unsigned long start, unsigned long end)
>  {
>  	if (!keep_initrd) {
>  		if (start == initrd_start)
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/