linux-kernel - RE: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <36DF59CE26D8EE47B0655C516E9CE6401CB01E3F@SHSMSX101.ccr.corp.intel.com>
Date:	Tue, 25 Aug 2015 01:58:18 +0000
From:	"Chen, Yu C" <yu.c.chen@...el.com>
To:	Borislav Petkov <bp@...en8.de>
CC:	"rjw@...ysocki.net" <rjw@...ysocki.net>,
	"pavel@....cz" <pavel@....cz>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"Zhang, Rui" <rui.zhang@...el.com>,
	"lenb@...nel.org" <lenb@...nel.org>,
	"x86@...nel.org" <x86@...nel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for
 suspend

Hi, Boris,thanks for your review

> -----Original Message-----
> From: Borislav Petkov [mailto:bp@...en8.de]
> Sent: Monday, August 24, 2015 4:50 PM
> To: Chen, Yu C
> Cc: rjw@...ysocki.net; pavel@....cz; tglx@...utronix.de;
> mingo@...hat.com; hpa@...or.com; Zhang, Rui; lenb@...nel.org;
> x86@...nel.org; linux-pm@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for
> suspend
> 
> On Fri, Aug 21, 2015 at 07:53:34PM +0800, Chen Yu wrote:
> > +struct msr_type {
> > +	unsigned int msr_id;
> > +	bool msr_saved;
> > +	u64 msr_value;
> > +};
> 
> These definitions look awfully close to struct msr_info in include/asm/msr.h
> 
> Maybe reuse them instead of growing yet another type...
> 
OK,  I'll use msr_info instead of  msr_id and msr_value:
struct msr_type {
	bool msr_saved;
	struct msr_info rv;
};

> > +static void msr_save_context(struct saved_context *ctxt) {
> > +	int i = 0;
> > +
> > +	for (i = 0; i < ctxt->msr_for_save.num; i++) {
> > +		struct msr_type *msr =
> > +			&ctxt->msr_for_save.msr_array[i];
> 
> No need for the line breaks here, let them stick out for better readability.
> 
OK, will do.
> > +		msr->msr_saved = !rdmsrl_safe(msr->msr_id,
> > +			&msr->msr_value);
> > +	}
> > +		struct msr_type *msr =
> > +			&ctxt->msr_for_save.msr_array[i];
> > +		if (msr->msr_saved)
> > +			wrmsrl(msr->msr_id, msr->msr_value);
> 
> Ditto.
> 
OK, will do.


Best Regards,
Yu