| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150825151154.19516.qmail@ns.horizon.com> Date: 25 Aug 2015 11:11:54 -0400 From: "George Spelvin" <linux@...izon.com> To: linux@...musvillemoes.dk, mingo@...nel.org Cc: dave@...1.net, linux-kernel@...r.kernel.org, linux-mm@...ck.org, linux@...izon.com, peterz@...radead.org, riel@...hat.com, rientjes@...gle.com, torvalds@...ux-foundation.org Subject: Re: [PATCH 3/3 v6] mm/vmalloc: Cache the vmalloc memory info >>> (I hope I'm not annoying you by bikeshedding this too much, although I >>> think this is improving.) >> >> [ I don't mind, although I wish other, more critical parts of the kernel got this >> much attention as well ;-) ] That's the problem with small, understandable problems: people *aren't* scared to mess with them. > It's been fun seeing this evolve, but overall, I tend to agree with > Peter: It's a lot of complexity for little gain. If we're not going to > just kill the Vmalloc* fields (which is probably too controversial) > I'd prefer Linus' simpler version. Are you sure you're not being affected by the number of iterations? The final version is not actually a lot of code (although yes, more than Linus's), and offers the advantage of peace of mind: there's not some nasty-smelling code you can't entirely trust left behind. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists