linux-kernel - Re: [PATCH v11 00/20] Compile-time stack validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150825152554.GA3724@treble.redhat.com>
Date:	Tue, 25 Aug 2015 10:25:54 -0500
From:	Josh Poimboeuf <jpoimboe@...hat.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, live-patching@...r.kernel.org,
	Michal Marek <mmarek@...e.cz>,
	Peter Zijlstra <peterz@...radead.org>,
	Andy Lutomirski <luto@...nel.org>,
	Borislav Petkov <bp@...en8.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>,
	Pedro Alves <palves@...hat.com>,
	Namhyung Kim <namhyung@...il.com>,
	Bernd Petrovitsch <bernd@...rovitsch.priv.at>,
	Chris J Arges <chris.j.arges@...onical.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	David Vrabel <david.vrabel@...rix.com>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Chris Wright <chrisw@...s-sol.org>,
	Alok Kataria <akataria@...are.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>,
	Pavel Machek <pavel@....cz>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <len.brown@...el.com>,
	Matt Fleming <matt.fleming@...el.com>
Subject: Re: [PATCH v11 00/20] Compile-time stack validation

On Tue, Aug 25, 2015 at 10:05:00AM +0200, Ingo Molnar wrote:
> * Josh Poimboeuf <jpoimboe@...hat.com> wrote:
> >  lib/Kconfig.debug                         |  11 +
> >  scripts/Makefile                          |   1 +
> >  scripts/Makefile.build                    |  37 +-
> >  scripts/mod/Makefile                      |   2 +
> >  scripts/stackvalidate/Makefile            |  24 +
> >  scripts/stackvalidate/arch-x86.c          | 160 +++++
> >  scripts/stackvalidate/arch.h              |  44 ++
> >  scripts/stackvalidate/elf.c               | 427 +++++++++++++
> >  scripts/stackvalidate/elf.h               |  92 +++
> >  scripts/stackvalidate/list.h              | 217 +++++++
> >  scripts/stackvalidate/special.c           | 199 ++++++
> >  scripts/stackvalidate/special.h           |  42 ++
> >  scripts/stackvalidate/stackvalidate.c     | 976 ++++++++++++++++++++++++++++++
> >  43 files changed, 2803 insertions(+), 48 deletions(-)
> >  create mode 100644 Documentation/stack-validation.txt
> >  create mode 100644 arch/x86/include/asm/stackvalidate.h
> >  create mode 100644 include/linux/stackvalidate.h
> >  create mode 100644 scripts/stackvalidate/Makefile
> >  create mode 100644 scripts/stackvalidate/arch-x86.c
> >  create mode 100644 scripts/stackvalidate/arch.h
> >  create mode 100644 scripts/stackvalidate/elf.c
> >  create mode 100644 scripts/stackvalidate/elf.h
> >  create mode 100644 scripts/stackvalidate/list.h
> >  create mode 100644 scripts/stackvalidate/special.c
> >  create mode 100644 scripts/stackvalidate/special.h
> >  create mode 100644 scripts/stackvalidate/stackvalidate.c
> 
> Btw., would you be against putting scripts/stackvalidate/ into 
> tools/stackvalidate/ ?
> 
> That way it would be more generic, and could be used in a standalone fashion as 
> well I suspect. It would not change any of your current usage of it.
> 
> (The other Kbuild glue changes still need to be in scripts/.)

I like that idea.  It could indeed be useful for any other projects
which have asm code.  In fact the musl project has been trying to solve
similar problems with their CFI generation awk script.

It does have some kernel-isms related to the reading of special sections
(.altinstructions, __jump_table, etc).  But that should be harmless for
non-kernel code and could easily be factored out with a compile-time or
cmdline flag if needed.

BTW, since I'm planning on adding a CFI generation option to this tool,
I wonder if "stackvalidate" is a misnomer.  I can't think of anything
better.  Any naming ideas are welcome :-)

-- 
Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/