linux-kernel - Re: [PATCH 02/10] mm: make slab_common.c explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55DC8ACE.1080804@windriver.com>
Date:	Tue, 25 Aug 2015 11:33:34 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Christoph Lameter <cl@...ux.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>, <linux-mm@...ck.org>,
	<linux-kernel@...r.kernel.org>, Pekka Enberg <penberg@...nel.org>,
	David Rientjes <rientjes@...gle.com>,
	Joonsoo Kim <iamjoonsoo.kim@....com>
Subject: Re: [PATCH 02/10] mm: make slab_common.c explicitly non-modular

On 2015-08-25 10:59 AM, Christoph Lameter wrote:
> On Mon, 24 Aug 2015, Paul Gortmaker wrote:
> 
>> @@ -1113,7 +1113,7 @@ static int __init slab_proc_init(void)
>>  						&proc_slabinfo_operations);
>>  	return 0;
>>  }
>> -module_init(slab_proc_init);
>> +device_initcall(slab_proc_init);
>>  #endif /* CONFIG_SLABINFO */
>>
>>  static __always_inline void *__do_krealloc(const void *p, size_t new_size,
> 
> True memory management is not a module. But its also not a device.

Per the 0/N I'd rather make it equivalent to what it was already
at this point in time and then consider making it a core_initcall
or post_core early in the next dev cycle if we want to give it
a more appropriately matching category, so we can then watch for
init reordering fallout with more time on our hands.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/