linux-kernel - Re: [PATCH] phylib: Make PHYs children of their MDIO bus, not the bus' parent.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150825.113136.806044696899448612.davem@davemloft.net>
Date:	Tue, 25 Aug 2015 11:31:36 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ddaney.cavm@...il.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	f.fainelli@...il.com, david.daney@...ium.com,
	buytenh@...tstofly.org, grant.likely@...retlab.ca
Subject: Re: [PATCH] phylib: Make PHYs children of their MDIO bus, not the
 bus' parent.

From: David Daney <ddaney.cavm@...il.com>
Date: Fri, 21 Aug 2015 16:16:03 -0700

> From: David Daney <david.daney@...ium.com>
> 
> commit 18ee49ddb0d2 ("phylib: rename mii_bus::dev to mii_bus::parent")
> changed the parent of PHY devices from the bus to the bus parent.
> 
> Then, commit 4dea547fef1b ("phylib: rework to prepare for OF
> registration of PHYs") moved the code into phy_device.c
> 
> At this point, it is somewhat unclear why the change was seen as
> necessary.  But, when we look at the device model tree in
> /sys/devices, it is clearly incorrect.  The PHYs should be children of
> their MDIO bus.
> 
> Change the PHY's parent device to be the MDIO bus device.
> 
> Cc: Lennert Buytenhek <buytenh@...tstofly.org>
> Cc: Grant Likely <grant.likely@...retlab.ca>
> Signed-off-by: David Daney <david.daney@...ium.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/