linux-kernel - RE: [scsi 5/7 RESEND] scsi_debug: schedule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Aug 2015 21:03:55 +0000
From:	"Winkler, Tomas" <tomas.winkler@...el.com>
To:	"emilne@...hat.com" <emilne@...hat.com>
CC:	James Bottomley <James.Bottomley@...senpartnership.com>,
	Christoph Hellwig <hch@....de>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Douglas Gilbert" <dgilbert@...erlog.com>
Subject: RE: [scsi 5/7 RESEND] scsi_debug: schedule_resp fix input variable
 check


> > +	/* this should never happen */
> > +	if (WARN_ON(!cmnd))
> > +		return SCSI_MLQUEUE_HOST_BUSY;
> >
> > -	if (NULL == cmnd || NULL == devip) {
> > -		pr_warn("called with NULL cmnd or devip pointer\n");
> > +	if (NULL == devip) {
> > +		pr_warn("called devip == NULL\n");
> >  		/* no particularly good error to report back */
> >  		return SCSI_MLQUEUE_HOST_BUSY;
> >  	}
> 
> Please refer to the patch I just posted, we can't return _HOST_BUSY here
> if devip == NULL.  I posted a fix against the current "misc" branch as
> I don't see this patch applied, let me know if I need to update it.


I'm just not sure why the patches are not merged or even rejected.
I'm submitting patches to the Linux kernel for more than 10 years to various trees and  I can agree that these are not some  urgent fixes, but  this is the first time my effort is ignored for such long time by the maintainer. 

Thanks
Tomas