linux-kernel - Re: [PATCH] nfsd: don't WARN/backtrace for invalid container deployment.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150825210642.GG3560@windriver.com>
Date:	Tue, 25 Aug 2015 17:06:43 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	<linux-kernel@...r.kernel.org>
CC:	"J. Bruce Fields" <bfields@...ldses.org>,
	<linux-nfs@...r.kernel.org>
Subject: Re: [PATCH] nfsd: don't WARN/backtrace for invalid container
 deployment.

[[PATCH] nfsd: don't WARN/backtrace for invalid container deployment.] On 25/08/2015 (Tue 16:59) Paul Gortmaker wrote:

> These messages, combined with the backtrace they trigger, makes it seem
> like a serious problem, though a quick search shows distros marking
> it as a "won't fix" non-issue when the problem is reported by users.

Ah crap, didn't notice I was on a slightly older kernel when generating
this ; it still applies to master with minor fuzz.  I can resend if need
be, and if folks are OK with the general approach.

Paul.
--

> 
> The backtrace is overkill, and only really manages to show that if
> you follow the code path, you can't really avoid it with bootargs
> or configuration settings in the container.
> 
> Given that, lets tone it down a bit and get rid of the WARN severity,
> and the associated backtrace, so people aren't needlessly alarmed.
> 
> Also, lets drop the split printk line, since they are grep unfriendly.
> 
> Cc: "J. Bruce Fields" <bfields@...ldses.org>
> Cc: linux-nfs@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> 
> diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c
> index 9c271f42604a..fe8a3da5eb63 100644
> --- a/fs/nfsd/nfs4recover.c
> +++ b/fs/nfsd/nfs4recover.c
> @@ -526,8 +526,7 @@ nfsd4_legacy_tracking_init(struct net *net)
>  
>  	/* XXX: The legacy code won't work in a container */
>  	if (net != &init_net) {
> -		WARN(1, KERN_ERR "NFSD: attempt to initialize legacy client "
> -			"tracking in a container!\n");
> +		pr_warn("NFSD: attempt to initialize legacy client tracking in a container ignored.\n");
>  		return -EINVAL;
>  	}
>  
> @@ -1191,8 +1190,7 @@ nfsd4_umh_cltrack_init(struct net __attribute__((unused)) *net)
>  {
>  	/* XXX: The usermode helper s not working in container yet. */
>  	if (net != &init_net) {
> -		WARN(1, KERN_ERR "NFSD: attempt to initialize umh client "
> -			"tracking in a container!\n");
> +		pr_warn("NFSD: attempt to initialize umh client tracking in a container ignored.\n");
>  		return -EINVAL;
>  	}
>  	return nfsd4_umh_cltrack_upcall("init", NULL, NULL);
> -- 
> 2.1.0
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/