linux-kernel - Re: [PATCH] usb: message: remove redundant declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 26 Aug 2015 00:12:41 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Kris Borer <kborer@...il.com>, gregkh@...uxfoundation.org
Cc:	stefan.koch10@...il.com, lkml14@...tdoyle.com,
	stern@...land.harvard.edu, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: message: remove redundant declaration

Hello.

On 08/25/2015 05:30 AM, Kris Borer wrote:

> Fix the Sparse warning:
>
> message.c:1390:21: warning: symbol 'i' shadows an earlier one
> message.c:1294:13: originally declared here
>
> Signed-off-by: Kris Borer <kborer@...il.com>
> ---
>   drivers/usb/core/message.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
> index f368d20..e83648d 100644
> --- a/drivers/usb/core/message.c
> +++ b/drivers/usb/core/message.c
> @@ -1387,7 +1387,6 @@ int usb_set_interface(struct usb_device *dev, int interface, int alternate)
>   	 * new altsetting.
>   	 */
>   	if (manual) {
> -		int i;
>

    Why not remove (now unneeded) empty line?

>   		for (i = 0; i < alt->desc.bNumEndpoints; i++) {
>   			epaddr = alt->endpoint[i].desc.bEndpointAddress;

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/