linux-kernel - Re: [PATCH v2] mmc: host: use of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFqjUZv2950ekKTiJCdt5TZe-YXWaX+DWeRbbep_AURSmg@mail.gmail.com>
Date:	Tue, 25 Aug 2015 23:19:02 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] mmc: host: use of_property_read_bool()

On 25 August 2015 at 18:32, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
> On 08/25/2015 03:05 PM, Ulf Hansson wrote:
>
>>> Use more compact of_property_read_bool() calls instead of the
>>> of_find_property()
>>> calls.
>
>
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
>
>
>> Thanks, applied for next!
>
>
>    Thanks to you! :-)
>
>> Next, time please run checkpatch to remove errors/warnings.
>
>
>    Hum, I just did and the patch seems clean:
>
> [headless@...ted mmc]$ scripts/checkpatch.pl
> patches/mmc-host-use-of_property_read_bool.patch
> total: 0 errors, 0 warnings, 81 lines checked
>
> patches/mmc-host-use-of_property_read_bool.patch has no obvious style
> problems and is ready for submission.
>
>    What do you mean?

WARNING: Possible unwrapped commit description (prefer a maximum 75
chars per line)
#12:
Use more compact of_property_read_bool() calls instead of the of_find_property()

total: 0 errors, 1 warnings, 81 lines checked

I suspect we might use different versions of the checkpatch script.
Mine is from 4.2rc7.

No worries then!

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/