linux-kernel - Re: [PATCH] cred: Remove unnecessary kdebug atomic reads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <22331.1440545444@warthog.procyon.org.uk>
Date:	Wed, 26 Aug 2015 00:30:44 +0100
From:	David Howells <dhowells@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	dhowells@...hat.com, Joe Perches <joe@...ches.com>,
	James Morris <jmorris@...ei.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cred: Remove unnecessary kdebug atomic reads

Andrew Morton <akpm@...ux-foundation.org> wrote:

> Did you consider doing this within no_printk()?  That would break code
> which is relying on side-effects in the evaluation of a printk arg but
> that's pretty weird and I bet there isn't (and won't be) such code.

The reasons that no_printk() is like it is are (1) so that the side-effects
stay intact and (2) you still get format warnings.  If someone prints a device
register, for example, it *must* work the same whether or not you use printk()
or no_printk().  Of course, printing a device register like this is probably
not a good idea...

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/