linux-kernel - Re: [PATCH 0/5] usb: common and dwc3: converting to unified device property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Aug 2015 12:53:20 +0800
From:	Peter Chen <peter.chen@...escale.com>
To:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
CC:	Felipe Balbi <balbi@...com>,
	David Cohen <david.a.cohen@...ux.intel.com>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/5] usb: common and dwc3: converting to unified device
 property

On Tue, Aug 25, 2015 at 02:04:30PM +0300, Heikki Krogerus wrote:
> Hi,
> 
> While converting dwc3 to the unified device property interface, I
> noticed that there is really nothing preventing of_usb_get_dr_mode and
> of_usb_get_maximum_speed from being converted as well. Hope that's OK.
> 

Place the reference for usb_get_dr_mode and usb_get_maximum_speed
at otg.h and ch9.h may not be good, why not add a common.h which
is at include/linux/usb/ too.

> The only special case was dwc3-st.c, where the dr_mode is requested
> before the platform device has been populated. I changed it so that
> the dr_mode property is requested after the platform device is
> populated in a separate patch.
> 
> 
> Heikki Krogerus (5):
>   usb: common: of_usb_get_maximum_speed to usb_get_maximum_speed
>   usb: dwc3: st: prepare the driver for generic usb_get_dr_mode function
>   usb: common: of_usb_get_dr_mode to usb_get_dr_mode
>   usb: dwc3: core: convert to unified device property interface
>   usb: dwc3: pci: passing forward the ACPI companion
> 
>  drivers/usb/chipidea/core.c     |  4 +--
>  drivers/usb/common/common.c     | 59 +++++++++++++++--------------------------
>  drivers/usb/dwc2/platform.c     |  2 +-
>  drivers/usb/dwc3/core.c         | 50 +++++++++++++++++-----------------
>  drivers/usb/dwc3/dwc3-pci.c     |  1 +
>  drivers/usb/dwc3/dwc3-st.c      | 12 +++++++--
>  drivers/usb/musb/musb_dsps.c    |  2 +-
>  drivers/usb/musb/sunxi.c        |  2 +-
>  drivers/usb/phy/phy-msm-usb.c   |  2 +-
>  drivers/usb/phy/phy-tegra-usb.c |  2 +-
>  include/linux/usb/ch9.h         | 11 +++++++-
>  include/linux/usb/of.h          | 12 ---------
>  include/linux/usb/otg.h         |  9 +++++++
>  13 files changed, 84 insertions(+), 84 deletions(-)
> 
> -- 
> 2.5.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/