linux-kernel - RE: [PATCH v7 10/17] KVM: x86: Update IRTE for posted-interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E959C4978C3B6342920538CF579893F0026C44D6@SHSMSX104.ccr.corp.intel.com>
Date:	Wed, 26 Aug 2015 00:36:13 +0000
From:	"Wu, Feng" <feng.wu@...el.com>
To:	Alex Williamson <alex.williamson@...hat.com>
CC:	"pbonzini@...hat.com" <pbonzini@...hat.com>,
	"joro@...tes.org" <joro@...tes.org>,
	"mtosatti@...hat.com" <mtosatti@...hat.com>,
	"eric.auger@...aro.org" <eric.auger@...aro.org>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Wu, Feng" <feng.wu@...el.com>
Subject: RE: [PATCH v7 10/17] KVM: x86: Update IRTE for posted-interrupts



> -----Original Message-----
> From: Alex Williamson [mailto:alex.williamson@...hat.com]
> Sent: Wednesday, August 26, 2015 3:58 AM
> To: Wu, Feng
> Cc: pbonzini@...hat.com; joro@...tes.org; mtosatti@...hat.com;
> eric.auger@...aro.org; kvm@...r.kernel.org;
> iommu@...ts.linux-foundation.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v7 10/17] KVM: x86: Update IRTE for posted-interrupts
> 
> On Tue, 2015-08-25 at 16:50 +0800, Feng Wu wrote:
> > This patch adds the routine to update IRTE for posted-interrupts
> > when guest changes the interrupt configuration.
> >
> > Signed-off-by: Feng Wu <feng.wu@...el.com>
> > ---
> >  arch/x86/kvm/x86.c | 73
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 73 insertions(+)
> > +		kvm_set_msi_irq(e, &irq);
> > +		if (!kvm_intr_is_single_vcpu(kvm, &irq, &vcpu))
> > +			continue;
> > +
> > +		vcpu_info.pi_desc_addr = kvm_x86_ops->get_pi_desc_addr(vcpu);
> > +		vcpu_info.vector = irq.vector;
> > +
> > +		if (set)
> > +			ret = irq_set_vcpu_affinity(host_irq, &vcpu_info);
> > +		else {
> > +			/* suppress notification event before unposting */
> > +			kvm_x86_ops->pi_set_sn(vcpu);
> > +			ret = irq_set_vcpu_affinity(host_irq, NULL);
> > +			kvm_x86_ops->pi_clear_sn(vcpu);
> > +		}
> 
> Can we add trace events so that we have a way to tell when PI is being
> enabled/disabled other than performance heuristics?  Thanks,

Sure, I will add it.

Thanks,
Feng

> 
> Alex
> > 
>