linux-kernel - RE: [PATCH v2 0/4] perf probe, tracing/uprobes: Support probing at absolute address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Aug 2015 09:12:19 +0000
From:	平松雅巳 / HIRAMATU，MASAMI 
	<masami.hiramatsu.pt@...achi.com>
To:	"'Wang Nan'" <wangnan0@...wei.com>,
	"acme@...nel.org" <acme@...nel.org>,
	"rostedt@...dmis.org" <rostedt@...dmis.org>
CC:	"mingo@...hat.com" <mingo@...hat.com>,
	"namhyung@...nel.org" <namhyung@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 0/4] perf probe, tracing/uprobes: Support probing at
 absolute address

> From: Wang Nan [mailto:wangnan0@...wei.com]
> 
> The goal of these 4 patches is to allow perf probing at absolute address
> for uprobes and kprobes. During the development several small problem in
> 'perf probe -l' is found and fixed.
> 
> Patch 1 has already acked by Masami Hiramatsu.
> 
> Patch 2 fixes a problem about zero address in perf side.
> 
> Patch 3 is the main patch of these 4. It allows following command:
> 
>  # perf probe /lib/x86_64-linux-gnu/libc-2.19.so 0xeb860
> 
>  Different from v1, no extra '+' is required.

Yeah, this seems better for me. Since '+' has double meanings "positive value" and
"add something", I think it's not good for this context.

> 
> Patch 4 is a kernel side patch which fixes a small problem in uprobe_event
> that, if address is 0, uprobe_events reports '0x  (null)'. It is independent
> from the other patches.

Oops, right.

Thanks!

> 
> Wang Nan (4):
>   perf probe: Prevent segfault when reading probe point with absolute
>     address
>   perf probe: Fix list result when address is zero
>   perf probe: Support probing at absolute address
>   tracing/uprobes: Do not print '0x  (null)' when offset is 0
> 
>  kernel/trace/trace_uprobe.c    |  17 +++-
>  tools/perf/util/probe-event.c  | 210 +++++++++++++++++++++++++++++++++++++----
>  tools/perf/util/probe-event.h  |   4 +
>  tools/perf/util/probe-finder.c |  21 +----
>  4 files changed, 216 insertions(+), 36 deletions(-)
> 
> --
> 1.8.3.4