linux-kernel - Re: [PATCH v4] pinctrl: mediatek: Fix multiple registration issue.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZThvKa2sCC5HE_=nQXc0nTD7t-EkGwm6Lq8AUqUUjGFQ@mail.gmail.com>
Date:	Wed, 26 Aug 2015 14:38:20 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Hongzhou Yang <hongzhou.yang@...iatek.com>
Cc:	Matthias Brugger <matthias.bgg@...il.com>,
	Axel Lin <axel.lin@...ics.com>,
	Yingjoe Chen <yingjoe.chen@...iatek.com>,
	Antoine Tenart <antoine.tenart@...e-electrons.com>,
	Maoguang Meng <maoguang.meng@...iatek.com>,
	Masahiro Yamada <yamada.masahiro@...ionext.com>,
	Chaotian Jing <chaotian.jing@...iatek.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	linux-mediatek@...ts.infradead.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	srv_heupstream@...iatek.com, Sascha Hauer <kernel@...gutronix.de>
Subject: Re: [PATCH v4] pinctrl: mediatek: Fix multiple registration issue.

On Wed, Aug 26, 2015 at 2:32 AM, Hongzhou Yang
<hongzhou.yang@...iatek.com> wrote:

> Since our common driver need support main chip and PMU
> at the same time, that means it will register two
> pinctrl device, and the pinctrl_desc structure should
> be used two times.
>
> But pinctrl_desc use global static definition, then
> the latest registered pinctrl device will overwrite
> the old one's, all members in pinctrl_desc will set to
> the new one's, such as name, pins and pins numbers, etc.
> This is a bug.
>
> Move pinctrl_desc into mtk_pinctrl, assign new value for
> each pinctrl device to fix it.
>
> Cc: stable@...r.kernel.org # v4.1+
> Signed-off-by: Hongzhou Yang <hongzhou.yang@...iatek.com>
> Reviewed-by: Axel Lin <axel.lin@...ics.com>
> ---
>  In order to fix multiple registration issue, move
>  pinctrl_desc into mtk_pinctrl, assign new value for
>  each pinctrl device.

This patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/