linux-kernel - Re: [PATCH 2/3] thermal: Add Mediatek thermal controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55DDC6F1.8090105@linaro.org>
Date:	Wed, 26 Aug 2015 16:02:25 +0200
From:	Daniel Lezcano <daniel.lezcano@...aro.org>
To:	Sascha Hauer <s.hauer@...gutronix.de>
CC:	linux-pm@...r.kernel.org, Zhang Rui <rui.zhang@...el.com>,
	Eduardo Valentin <edubezval@...il.com>,
	linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
	Daniel Kurtz <djkurtz@...omium.org>, kernel@...gutronix.de,
	Matthias Brugger <matthias.bgg@...il.com>
Subject: Re: [PATCH 2/3] thermal: Add Mediatek thermal controller support

On 08/26/2015 03:54 PM, Sascha Hauer wrote:
> On Fri, Aug 21, 2015 at 01:12:23AM +0200, Daniel Lezcano wrote:
>> On 08/20/2015 10:06 AM, Sascha Hauer wrote:
>>> This adds support for the Mediatek thermal controller found on MT8173
>>> and likely other SoCs.
>>> The controller is a bit special. It does not have its own ADC, instead
>>> it controls the on-SoC AUXADC via AHB bus accesses. For this reason
>>> we need the physical address of the AUXADC. Also it controls a mux
>>> using AHB bus accesses, so we need the APMIXEDSYS physical address aswell.
>>>
>>> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
>>> ---
>>
>> [ ... ]
>>
>>> diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
>>> new file mode 100644
>>> index 0000000..06d52ef
>>> --- /dev/null
>>> +++ b/drivers/thermal/mtk_thermal.c
>>> @@ -0,0 +1,582 @@
>>> +/*
>>> + * Copyright (c) 2014 MediaTek Inc.
>>
>> 2015 ?
>
> Can change to 2015
>
>>
>>> + * Author: Hanyi.Wu <hanyi.wu@...iatek.com>
>>
>> Hanyi Wu ?
>
> It's the original author of this code.

Sorry I wasn't clear. I was suggesting to remove the dot between Hanyi 
and Wu.

>>> +#define TEMP_MONINT_COLD(sp)			(BIT(0) << ((sp) * 5))
>>> +#define TEMP_MONINT_HOT(sp)			(BIT(1) << ((sp) * 5))
>>> +#define TEMP_MONINT_LOW_OFS(sp)			(BIT(2) << ((sp) * 5))
>>> +#define TEMP_MONINT_HIGH_OFS(sp)		(BIT(3) << ((sp) * 5))
>>> +#define TEMP_MONINT_HOT_TO_NORM(sp)		(BIT(4) << ((sp) * 5))
>>> +#define TEMP_MONINT_TIMEOUT			BIT(15)
>>> +#define TEMP_MONINT_IMMEDIATE_SENSE(sp)		BIT(16 + (sp))
>>> +#define TEMP_MONINT_FILTER_SENSE(sp)		BIT(19 + (sp))
>>> +#define TEMP_ADCWRITECTRL_ADC_EXTRA_WRITE	BIT(2)
>>> +#define TEMP_ADCWRITECTRL_ADC_EXTRA1_WRITE	BIT(3)
>>> +#define TEMP_PROTCTL_AVERAGE			(0 << 16)
>>> +#define TEMP_PROTCTL_MAXIMUM			(1 << 16)
>>> +#define TEMP_PROTCTL_SELECTED			(2 << 16)
>>
>> <-- Not used.
>
> Will remove.
>
> Sascha
>
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/