linux-kernel - Re: [PATCH] of: device: fix NULL pointer dereference on driver removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150826141221.GB14625@saruman.tx.rr.com>
Date:	Wed, 26 Aug 2015 09:12:21 -0500
From:	Felipe Balbi <balbi@...com>
To:	Rob Herring <robherring2@...il.com>
CC:	Felipe Balbi <balbi@...com>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux OMAP Mailing List <linux-omap@...r.kernel.org>,
	stable <stable@...r.kernel.org>
Subject: Re: [PATCH] of: device: fix NULL pointer dereference on driver
 removal

On Wed, Aug 26, 2015 at 08:14:36AM -0500, Rob Herring wrote:
> On Tue, Aug 25, 2015 at 2:34 PM, Felipe Balbi <balbi@...com> wrote:
> > If we don't insert resources into the resource tree,
> > calls to of_platform_depopulate() will end up in NULL
> > pointer dereferences because the resource parent will
> > be set to NULL even though we still have more resources
> > to go through.
> 
> Long standing problem. A fix is in -next now and will go into 4.3 (plus stable):
> 
> commit 11c63e4718acad3d8f04601c80fddd4b3d1455b1
> Author: Grant Likely <grant.likely@...aro.org>
> Date:   Sun Jun 7 15:20:11 2015 +0100
> 
>     drivercore: Fix unregistration path of platform devices

that commit works, but too late to add a Tested-by :-)

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)