lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1440599790.2196.9.camel@HansenPartnership.com>
Date:	Wed, 26 Aug 2015 07:36:30 -0700
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	Kashyap Desai <kashyap.desai@...gotech.com>,
	Uday Lingala <uday.lingala@...gotech.com>,
	Sumit Saxena <sumit.saxena@...gotech.com>,
	megaraidlinux.pdl@...gotech.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Joe Perches <joe@...ches.com>,
	Christoph Hellwig <hch@....de>
Subject: Re: [PATCH v3 3/3] megaraid_sas : fix whitespace errors

On Tue, 2015-07-07 at 15:52 -0500, Bjorn Helgaas wrote:
> Fix whitespace and indentation errors.  No code change.

checkpatch says you missed one:

ERROR: space required after that ',' (ctx:VxV)
#860: FILE: drivers/scsi/megaraid/megaraid_sas_base.c:6457:
+       if (sscanf(buf,"%u",&megasas_dbg_lvl) < 1) {
                      ^

ERROR: space required after that ',' (ctx:VxO)
#860: FILE: drivers/scsi/megaraid/megaraid_sas_base.c:6457:
+       if (sscanf(buf,"%u",&megasas_dbg_lvl) < 1) {
                           ^

ERROR: space required before that '&' (ctx:OxV)
#860: FILE: drivers/scsi/megaraid/megaraid_sas_base.c:6457:
+       if (sscanf(buf,"%u",&megasas_dbg_lvl) < 1) {


I fixed it up

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ