linux-kernel - RE: [v2] net: phy: fixed: propagate fixed link values to struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BL2PR03MB545D559B9B04BFED6DE4266E6600@BL2PR03MB545.namprd03.prod.outlook.com>
Date:	Wed, 26 Aug 2015 16:12:43 +0000
From:	Madalin-Cristian Bucur <madalin.bucur@...escale.com>
To:	Stas Sergeev <stsp@...t.ru>,
	"f.fainelli@...il.com" <f.fainelli@...il.com>,
	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Liberman Igal <Igal.Liberman@...escale.com>
Subject: RE: [v2] net: phy: fixed: propagate fixed link values to struct

> -----Original Message-----
> From: Stas Sergeev [mailto:stsp@...t.ru]
> Sent: Wednesday, August 26, 2015 6:51 PM
> To: Bucur Madalin-Cristian-B32716 <madalin.bucur@...escale.com>;
> f.fainelli@...il.com
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Liberman Igal-
> B31950 <Igal.Liberman@...escale.com>
> Subject: Re: [v2] net: phy: fixed: propagate fixed link values to struct
> 
> 26.08.2015 17:58, Madalin Bucur пишет:
> > The fixed link values parsed from the device tree are stored in
> > the struct fixed_phy member status. The struct phy_device members
> > speed, duplex were not updated.
> 
> ACK, but IMHO it will make more sense if you include that
> into your upcoming patch set rather than sending separately,
> as otherwise there is simply no in-kernel users of that new
> functionality (all the current users likely do not access
> these fields as early as you want to, so they don't care).
> In any case, the patch looks good to me and the policy is
> up to others.

Given that it's more of a fix than a feature, I think it can be picked up separate
from a certain driver that accesses those fields early but I guess Florian, David
will decide this.

Thanks,
Madalin