linux-kernel - Re: [PATCH 1/3] timer: Optimize fastpath_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150826165757.3001.qmail@ns.horizon.com>
Date:	26 Aug 2015 12:57:57 -0400
From:	"George Spelvin" <linux@...izon.com>
To:	jason.low2@...com
Cc:	akpm@...ux-foundation.org, linux@...izon.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] timer: Optimize fastpath_timer_check()

> 	if (!task_cputime_zero(&tsk->cputime_expires)) {
>+		struct task_cputime task_sample;
>+		cputime_t utime, stime;
>+
>+		task_cputime(tsk, &utime, &stime);
>+		task_sample.utime = utime;
>+		task_sample.stime = stime;
>+		task_sample.sum_exec_runtime = tsk->se.sum_exec_runtime;

Er, task_sample.[us]time are already the correct types.
Whay are the local variables necessary?  How about:

 	if (!task_cputime_zero(&tsk->cputime_expires)) {
+		struct task_cputime task_sample;
+
+		task_cputime(tsk, &task_simple.utime, &task_simple.stime);
+		task_sample.sum_exec_runtime = tsk->se.sum_exec_runtime;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/