[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CANCZXo4jP1X8kwj2vA3ms+2F5vWG7W7meWY0sJEY+R9dDO9T=A@mail.gmail.com>
Date: Thu, 27 Aug 2015 01:12:22 +0600
From: Alexander Kuleshov <kuleshovmail@...il.com>
To: Tillmann Heidsieck <theidsieck@...nox.de>
Cc: Martin Schwidefsky <schwidefsky@...ibm.com>,
Heiko Carstens <heiko.carstens@...ibm.com>,
linux390@...ibm.com, linux-s390@...r.kernel.org,
LKML <linux-kernel@...r.kernel.org>,
linux-kernel-owner@...r.kernel.org
Subject: Re: [PATCH] s390/jump_label: Use %*ph to print small buffers
Hello Tillmann, sorry for noise, will resend.
2015-08-27 1:03 GMT+06:00 Tillmann Heidsieck <theidsieck@...nox.de>:
> Hi Alexander,
>
> On 2015-08-26 20:49, Alexander Kuleshov wrote:
>>
>> printk() supports %*ph format specifier for printing a small buffers,
>> let's use it intead of %02x %02x...
>
>
> noble effort ...
>
>> pr_emerg("Jump label code mismatch at %pS [%p]\n", ipc, ipc);
>> - pr_emerg("Found: %02x %02x %02x %02x %02x %02x\n",
>> + pr_emerg("Found: %6ph\n",
>> ipc[0], ipc[1], ipc[2], ipc[3], ipc[4], ipc[5]);
>> - pr_emerg("Expected: %02x %02x %02x %02x %02x %02x\n",
>> + pr_emerg("Expected: %6ph\n",
>> ipe[0], ipe[1], ipe[2], ipe[3], ipe[4], ipe[5]);
>> - pr_emerg("New: %02x %02x %02x %02x %02x %02x\n",
>> + pr_emerg("New: %6ph\n",
>> ipn[0], ipn[1], ipn[2], ipn[3], ipn[4], ipn[5]);
>> panic("Corrupted kernel text");
>> }
>
>
> ... but you might want to check our code before submission (e.g. compile
> it!)
>
> Cheers
> Tillmann
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists