linux-kernel - RE: [PATCH] Input: only send a syn event when needed in input_dev_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4B6D6D87A8FB62428BE0A3E38461A1AB2E468A20@irsmsx105.ger.corp.intel.com>
Date:	Thu, 27 Aug 2015 08:38:06 +0000
From:	"Holmberg, Hans" <hans.holmberg@...el.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	"Li, Ting" <ting.li@...el.com>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] Input: only send a syn event when needed in
 input_dev_release_keys

Hi Dmitry,

> We already have a similar commit
> 00159f19a5057cb779146afce1cceede692af346 in next.

That'll fix the problem. I'll make sure to keep an eye on your tree & -next in the future. 
My patch doesn’t add much (it does avoid the memset when there are no bits to clear however)

Cheers!

> > ---
> >  drivers/input/input.c | 12 +++++++++---
> >  1 file changed, 9 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/input/input.c b/drivers/input/input.c index
> > 78d2499..c748805 100644
> > --- a/drivers/input/input.c
> > +++ b/drivers/input/input.c
> > @@ -675,12 +675,18 @@ EXPORT_SYMBOL(input_close_device);
> >  static void input_dev_release_keys(struct input_dev *dev)  {
> >         int code;
> > +       bool key_released = false;
> >
> >         if (is_event_supported(EV_KEY, dev->evbit, EV_MAX)) {
> > -               for_each_set_bit(code, dev->key, KEY_CNT)
> > +               for_each_set_bit(code, dev->key, KEY_CNT) {
> >                         input_pass_event(dev, EV_KEY, code, 0);
> > -               memset(dev->key, 0, sizeof(dev->key));
> > -               input_pass_event(dev, EV_SYN, SYN_REPORT, 1);
> > +                       key_released = true;
> > +               }
> > +
> > +               if (key_released) {
> > +                       memset(dev->key, 0, sizeof(dev->key));
> > +                       input_pass_event(dev, EV_SYN, SYN_REPORT, 1);
> > +               }
> >         }
> >  }
> >
> > --
> > 1.9.1
> >
> 
> 
> 
> --
> Dmitry