linux-kernel - [PATCH V3] mm: memory hot-add: memory can not be added to movable zone defaultly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1440665641-3839-1-git-send-email-liuchangsheng@inspur.com>
Date:	Thu, 27 Aug 2015 04:54:01 -0400
From:	Changsheng Liu <liuchangsheng@...pur.com>
To:	<akpm@...ux-foundation.org>, <isimatu.yasuaki@...fujitsu.com>,
	<vbabka@...e.cz>
CC:	<linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
	<wunan@...pur.com>, <yanxiaofeng@...pur.com>,
	<liuchangsheng@...pur.com>, <fandd@...pur.com>,
	Changsheng Liu <liuchangcheng@...pur.com>
Subject: [PATCH V3] mm: memory hot-add: memory can not be added to movable zone defaultly

From: Changsheng Liu <liuchangcheng@...pur.com>

After the user config CONFIG_MOVABLE_NODE and movable_node kernel option,
When the memory is hot added, should_add_memory_movable() return 0
because all zones including movable zone are empty,
so the memory that was hot added will be added  to the normal zone
and the normal zone will be created firstly.
But we want the whole node to be added to movable zone defaultly.

So we change should_add_memory_movable(): if the user config
CONFIG_MOVABLE_NODE and movable_node kernel option
it will always return 1 and all zones is empty at the same time,
so that the movable zone will be created firstly
and then the whole node will be added to movable zone defaultly.
If we want the node to be added to normal zone,
we can do it as follows:
"echo online_kernel > /sys/devices/system/memory/memoryXXX/state"

If the memory is added to movable zone defaultly,
the user can offline it and add it to other zone again.
But if the memory is added to normal zone defaultly,
the user will not offline the memory used by kernel.

Reviewed-by: Andrew Morton <akpm@...ux-foundation.org>
Signed-off-by: Changsheng Liu <liuchangcheng@...pur.com>i
Tested-by: Dongdong Fan <fandd@...pur.com>
---
 mm/memory_hotplug.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 26fbba7..b5f14fa 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -1198,6 +1198,9 @@ static int should_add_memory_movable(int nid, u64 start, u64 size)
 	pg_data_t *pgdat = NODE_DATA(nid);
 	struct zone *movable_zone = pgdat->node_zones + ZONE_MOVABLE;

+	if (movable_node_is_enabled())
+		return 1;
+
 	if (zone_is_empty(movable_zone))
 		return 0;

-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/