linux-kernel - Re: [PATCH] cpufreq: powernv: Increase the verbosity of OCC console messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150827122940.GW8784@linux>
Date:	Thu, 27 Aug 2015 17:59:40 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Shilpasri G Bhat <shilpa.bhat@...ux.vnet.ibm.com>
Cc:	rjw@...ysocki.net, stewart@...ux.vnet.ibm.com,
	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org
Subject: Re: [PATCH] cpufreq: powernv: Increase the verbosity of OCC console
 messages

On 27-08-15, 14:41, Shilpasri G Bhat wrote:
> Modify the OCC reset/load/active event message to make it clearer for
> the user to understand the event and effect of the event.
> 
> Suggested-by: Stewart Smith <stewart@...ux.vnet.ibm.com>
> Signed-off-by: Shilpasri G Bhat <shilpa.bhat@...ux.vnet.ibm.com>
> ---
> This patch is based on top of linux-next/master
> 
>  drivers/cpufreq/powernv-cpufreq.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c
> index 546e056..64994e1 100644
> --- a/drivers/cpufreq/powernv-cpufreq.c
> +++ b/drivers/cpufreq/powernv-cpufreq.c
> @@ -465,6 +465,7 @@ static int powernv_cpufreq_occ_msg(struct notifier_block *nb,
>  	switch (omsg.type) {
>  	case OCC_RESET:
>  		occ_reset = true;
> +		pr_info("OCC (On Chip Controller - enforces hard thermal/power limits) Resetting\n");
>  		/*
>  		 * powernv_cpufreq_throttle_check() is called in
>  		 * target() callback which can detect the throttle state
> @@ -474,12 +475,12 @@ static int powernv_cpufreq_occ_msg(struct notifier_block *nb,
>  		 */
>  		if (!throttled) {
>  			throttled = true;
> -			pr_crit("CPU Frequency is throttled\n");
> +			pr_crit("CPU frequency is throttled for duration\n");
>  		}
> -		pr_info("OCC: Reset\n");
> +
>  		break;
>  	case OCC_LOAD:
> -		pr_info("OCC: Loaded\n");
> +		pr_info("OCC Loading, CPU frequency is throttled until OCC is started\n");
>  		break;
>  	case OCC_THROTTLE:
>  		omsg.chip = be64_to_cpu(msg->params[1]);
> @@ -488,7 +489,7 @@ static int powernv_cpufreq_occ_msg(struct notifier_block *nb,
>  		if (occ_reset) {
>  			occ_reset = false;
>  			throttled = false;
> -			pr_info("OCC: Active\n");
> +			pr_info("OCC Active, CPU frequency is no longer throttled\n");
>  
>  			for (i = 0; i < nr_chips; i++) {
>  				chips[i].restore = true;

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/