linux-kernel - Re: [PATCH] mmc: enable mmc host device to suspend/resume asynchronously

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFpRpGyCCoOU44CwiUxsJW1fMs8FxShvVga+uFHKvy7BBQ@mail.gmail.com>
Date:	Thu, 27 Aug 2015 15:05:58 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	"Fu, Zhonghui" <zhonghui.fu@...ux.intel.com>
Cc:	Adrian Hunter <adrian.hunter@...el.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Markus Niebel <Markus.Niebel@...group.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Kristina Martšenko <kristina.martsenko@...il.com>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: enable mmc host device to suspend/resume asynchronously

On 3 August 2015 at 14:39, Fu, Zhonghui <zhonghui.fu@...ux.intel.com> wrote:
> Enable mmc host device to suspend/resume asynchronously.
> This can improve system suspend/resume speed.

Can or will?

It would be nice to see some statistics of this to justify the change.
Can you share that?

Moreover we already have the runtime PM support, which enables the
reinitialization sequence of the mmc/sd card to be postponed from the
system PM resume path. Instead that's done when the next
pm_runtime_get_sync() for the card's device gets called. You my tried
that feature by enabling MMC_CAP_RUNTIME_RESUME for the mmc hosts.

Kind regards
Uffe

>
> Signed-off-by: Zhonghui Fu <zhonghui.fu@...ux.intel.com>
> ---
>  drivers/mmc/core/host.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> index 99a9c90..85f2bbb 100644
> --- a/drivers/mmc/core/host.c
> +++ b/drivers/mmc/core/host.c
> @@ -577,6 +577,7 @@ struct mmc_host *mmc_alloc_host(int extra, struct device *dev)
>         host->class_dev.parent = dev;
>         host->class_dev.class = &mmc_host_class;
>         device_initialize(&host->class_dev);
> +       device_enable_async_suspend(&host->class_dev);
>
>         if (mmc_gpio_alloc(host)) {
>                 put_device(&host->class_dev);
> -- 1.7.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/