linux-kernel - Re: [PATCH] mmc: block: disable the reliable write If the card does not support CMD23

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFpVN8aK6aF2Fk9UNgFfJU5W1CT4v4YBtJDF6t57cwXsKg@mail.gmail.com>
Date:	Thu, 27 Aug 2015 15:22:44 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Yong Li <sdliyong@...il.com>
Cc:	Chris Ball <chris@...ntf.net>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: block: disable the reliable write If the card does
 not support CMD23

On 25 August 2015 at 14:06, Ulf Hansson <ulf.hansson@...aro.org> wrote:
> On 14 August 2015 at 09:30,  <sdliyong@...il.com> wrote:
>> From: Yong Li <sdliyong@...il.com>
>>
>> Signed-off-by: Yong Li <sdliyong@...il.com>
>> ---
>>  drivers/mmc/card/block.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
>> index 452782b..d9e3c45 100644
>> --- a/drivers/mmc/card/block.c
>> +++ b/drivers/mmc/card/block.c
>> @@ -1366,7 +1366,8 @@ static void mmc_blk_rw_rq_prep(struct mmc_queue_req *mqrq,
>>         bool do_rel_wr = ((req->cmd_flags & REQ_FUA) ||
>>                           (req->cmd_flags & REQ_META)) &&
>>                 (rq_data_dir(req) == WRITE) &&
>> -               (md->flags & MMC_BLK_REL_WR);
>> +               (md->flags & MMC_BLK_REL_WR) &&
>> +               !(card->quirks & MMC_QUIRK_BLK_NO_CMD23);
>
> Further down in mmc_blk_rw_rq_prep() we check for
> MMC_QUIRK_BLK_NO_CMD23. That check becomes redundant after this
> change, please remove that check as a part of this patch as well.
>
>>
>>         memset(brq, 0, sizeof(struct mmc_blk_request));
>>         brq->mrq.cmd = &brq->cmd;
>> --
>> 2.1.0
>>
>

Please ignore my previous answer. MMC_QUIRK_BLK_NO_CMD23 is intended
to indicate to the mmc block layer whether using CMD23 for regular
block IO request could have a performance impact for some cards. If
that's the case we don't use it - except when using reliable write!

So this patch is just plain wrong.

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/