linux-kernel - Re: [PATCH] tools lib traceeveent: Allow for negative numbers in print format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55DF16EC.7070606@suse.cz>
Date:	Thu, 27 Aug 2015 15:55:56 +0200
From:	Vlastimil Babka <vbabka@...e.cz>
To:	Steven Rostedt <rostedt@...dmis.org>,
	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH] tools lib traceeveent: Allow for negative numbers in
 print format

On 08/27/2015 03:46 PM, Steven Rostedt wrote:
>
> It was reported that "%-8s" does not parse well when used in the printk
> format. The '-' is what is throwing it off. Allow that to be included.
>
> Reported-by: Vlastimil Babka <vbabka@...e.cz>

Reported-and-tested-by: Vlastimil Babka <vbabka@...e.cz>

Example before:
transhuge-stres-10730 [004]  5897.713989: mm_compaction_finished: node=0 
zone=>-<8s order=-2119871790 ret=

Example after:
transhuge-stres-4235  [000]   453.149280: mm_compaction_finished: node=0 
zone=ffffffff81815d7a order=9 ret=

(I will send patches to fix the string handling in the tracepoints so 
it's on par with in-kernel printing via trace_pipe:)

transhuge-stres-10921 [007] ...1  6307.140205: mm_compaction_finished: 
node=0 zone=Normal   order=9 ret=partial

> Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
> ---
>   tools/lib/traceevent/event-parse.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> index cc25f059ab3d..3b01ae137d95 100644
> --- a/tools/lib/traceevent/event-parse.c
> +++ b/tools/lib/traceevent/event-parse.c
> @@ -4754,6 +4754,7 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct event
>   			case 'z':
>   			case 'Z':
>   			case '0' ... '9':
> +			case '-':
>   				goto cont_process;
>   			case 'p':
>   				if (pevent->long_size == 4)
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/