linux-kernel - Re: [PATCH] scsi: fix scsi_error_handler vs. scsi_host_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPcyv4hYtKNgLoOBKfvUx==LnK34Ve7K+oYq7j1g6r0pAY8Cqg@mail.gmail.com>
Date:	Thu, 27 Aug 2015 11:28:05 -0700
From:	Dan Williams <dan.j.williams@...el.com>
To:	mhocko@...nel.org
Cc:	"James E.J. Bottomley" <JBottomley@...n.com>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Michal Hocko <mhocko@...e.com>
Subject: Re: [PATCH] scsi: fix scsi_error_handler vs. scsi_host_dev_release race

On Thu, Aug 27, 2015 at 11:16 AM,  <mhocko@...nel.org> wrote:
> From: Michal Hocko <mhocko@...e.com>
>
> b9d5c6b7ef57 ("[SCSI] cleanup setting task state in
> scsi_error_handler()") has introduced a race between scsi_error_handler
> and scsi_host_dev_release resulting in the hang when the device goes
> away because scsi_error_handler might miss a wake up:
>
> CPU0                                    CPU1
> scsi_error_handler                      scsi_host_dev_release
>                                           kthread_stop()
>   kthread_should_stop()
>     test_bit(KTHREAD_SHOULD_STOP)
>                                             set_bit(KTHREAD_SHOULD_STOP)
>                                             wake_up_process()
>                                             wait_for_completion()
>
>   set_current_state(TASK_INTERRUPTIBLE)
>   schedule()
>
> The most straightforward solution seems to be to invert the ordering of
> the set_current_state and kthread_should_stop.
>
> The issue has been noticed during reboot test on a 3.0 based kernel but
> the current code seems to be affected in the same way.
>
> Cc: stable # 3.6+
> Reported-and-Debugged-by: Mike Mayer <Mike.Meyer@...adata.com>
> Signed-off-by: Michal Hocko <mhocko@...e.com>

Acked-by: Dan Williams <dan.j.williams@...el.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/