linux-kernel - Re: [PATCH v3] selftests/zram: Adding zram tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 27 Aug 2015 16:12:07 -0600
From:	Shuah Khan <shuahkh@....samsung.com>
To:	naresh.kamboju@...aro.org, linux-kernel@...r.kernel.org
Cc:	tyler.baker@...aro.org, milosz.wasilewski@...aro.org,
	alexey.kodanev@...cle.com, Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH v3] selftests/zram: Adding zram tests

On 08/27/2015 12:10 PM, Shuah Khan wrote:
> On 08/18/2015 01:01 AM, naresh.kamboju@...aro.org wrote:
>> From: Naresh Kamboju <naresh.kamboju@...aro.org>
>>
>> zram: Compressed RAM based block devices
>> ----------------------------------------
>> The zram module creates RAM based block devices named /dev/zram<id>
>> (<id> = 0, 1, ...). Pages written to these disks are compressed and stored
>> in memory itself. These disks allow very fast I/O and compression provides
>> good amounts of memory savings. Some of the usecases include /tmp storage,
>> use as swap disks, various caches under /var and maybe many more :)
>>
>> Statistics for individual zram devices are exported through sysfs nodes at
>> /sys/block/zram<id>/
>>
>> This patch is to validate the zram functionality. Test interacts with block
>> device /dev/zram<id> and sysfs nodes /sys/block/zram<id>/
>>
> 
> Hi Naresh,
> 
> This doesn't fail gracefully when a regular user runs it. Please add
> a check for root and make the test fail gracefully when a non-root
> user runs it.
> 
> Please refer to tools/testing/selftests/efivarfs/efivarfs.sh
> for an example on how to check for root.
> 
> I was getting ready to apply this to linux-kselftest next for 4.3
> and ran some sanity tests. If you get me new revision quickly
> I can get it into 4.3-rc1.

Hi Naresh,

The patch is now in linux-kselftest next. Please send a fix in for
the non-root case for me get it into 4.3-rc1 or rc2.

thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@....samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/