linux-kernel - Re: linux-next: build failure after merge of the sound-asoc tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1508280936240.16666@lnxricardw1.se.axis.com>
Date:	Fri, 28 Aug 2015 09:40:41 +0200
From:	Ricard Wanderlof <ricard.wanderlof@...s.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
CC:	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the sound-asoc tree


On Fri, 28 Aug 2015, Stephen Rothwell wrote:

> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> In file included from sound/soc/codecs/ics43432.c:12:0:
> sound/soc/codecs/ics43432.c:60:25: error: 'ics43432_dt_ids' undeclared here (not in a function)
>  MODULE_DEVICE_TABLE(of, ics43432_dt_ids);
>                          ^
> include/linux/module.h:223:21: note: in definition of macro 'MODULE_DEVICE_TABLE'
>  extern const typeof(name) __mod_##type##__##name##_device_table  \
>                      ^
> include/linux/module.h:223:27: error: '__mod_of__ics43432_dt_ids_device_table' aliased to undefined symbol 'ics43432_dt_ids'
>  extern const typeof(name) __mod_##type##__##name##_device_table  \
>                            ^ 
> sound/soc/codecs/ics43432.c:60:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
>  MODULE_DEVICE_TABLE(of, ics43432_dt_ids);
>  ^
> 
> Caused by commit
> 
>   3b7ce99748f0 ("ASoC: ics43432: Add codec driver for InvenSense ICS-43432")
> 
> Not really build tested with CONFIG_OF set, right? :-(

Well, actually, yes.

In fact the exact same construct is used by a handful of other codec 
drivers which apparently don't fail.

I'm suspecting something slightly more convoluted like a missing #include .

> I have reverted that commit for today.

Ok. I'll get to work on this ASAP.

/Ricard
-- 
Ricard Wolf Wanderlöf                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/