linux-kernel - Re: [PATCH] S390: add pci_iomap_wc() and pci_iomap_wc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55E01A43.9080109@roeck-us.net>
Date:	Fri, 28 Aug 2015 01:22:27 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Ingo Molnar <mingo@...nel.org>,
	"Luis R. Rodriguez" <mcgrof@...not-panic.com>
CC:	schwidefsky@...ibm.com, heiko.carstens@...ibm.com,
	linux-s390@...r.kernel.org, bp@...e.de, plagnioj@...osoft.com,
	tomi.valkeinen@...com, linux-fbdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, fengguang.wu@...el.com,
	akpm@...ux-foundation.org, rostedt@...dmis.org,
	"Luis R. Rodriguez" <mcgrof@...e.com>
Subject: Re: [PATCH] S390: add pci_iomap_wc() and pci_iomap_wc_range()

On 08/27/2015 11:06 PM, Ingo Molnar wrote:
>
> * Luis R. Rodriguez <mcgrof@...not-panic.com> wrote:
>
>> From: "Luis R. Rodriguez" <mcgrof@...e.com>
>>
>> S390 requires its own implementation of pcio_iomap*() calls
>> is because it has its "BAR spaces are not disjunctive on s390
>> so we need the bar parameter of pci_iomap to find the corresponding
>> device and create the mapping cookie" -- in summary, it has its own
>> lookup/lock solution.
>>
>> It does not include asm-generic/pci_iomap.h
>>
>> Since it currenty maps ioremap_wc() to ioremap_nocache() and that's
>> the architecture default we can easily just map the wc calls to
>> the default calls as well.
>>
>> Cc: Guenter Roeck <linux@...ck-us.net>
>> Cc: Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
>> Cc: Tomi Valkeinen <tomi.valkeinen@...com>
>> Cc: linux-fbdev@...r.kernel.org
>> Cc: linux-kernel@...r.kernel.org
>> Cc: Borislav Petkov <bp@...e.de>
>> Cc: Ingo Molnar <mingo@...nel.org>
>> Cc: Fengguang Wu <fengguang.wu@...el.com>
>> Cc: Andrew Morton <akpm@...ux-foundation.org>
>> Cc: Steven Rostedt <rostedt@...dmis.org>
>> Reported-by: 0 day bot
>> Signed-off-by: Luis R. Rodriguez <mcgrof@...e.com>
>> ---
>>
>> This broke through some series that went into Ingo's tip tree which
>> I added. As such I *think* this should go through Ingo's tip tree.
>> Let me know. Up to you guys.
>
> I fixed the changelog to explain all this.
>
> Also, is there any other architecture that got broken by:
>
>     1b3d4200c1e0 PCI: Add pci_iomap_wc() variants
>

Should be the only one. There are only two implementations of pci_iomap(),
one in s390 code and the generic implementation.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/