linux-kernel - Re: [PATCH V4 2/2] PM / OPP: Fix static checker warning (broken 64bit big endian systems)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20319405.E46lXZHqyF@vostro.rjw.lan>
Date:	Fri, 28 Aug 2015 16:14:33 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	linaro-kernel@...ts.linaro.org, linux-pm@...r.kernel.org,
	dan.carpenter@...cle.com, nm@...com, sboyd@...eaurora.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Len Brown <len.brown@...el.com>,
	open list <linux-kernel@...r.kernel.org>,
	Pavel Machek <pavel@....cz>
Subject: Re: [PATCH V4 2/2] PM / OPP: Fix static checker warning (broken 64bit big endian systems)

On Monday, August 17, 2015 07:20:20 PM Viresh Kumar wrote:
> Dan Carpenter reported (generated with static checker):
> 
> drivers/base/power/opp.c:949 _opp_add_static_v2()
> warn: passing casted pointer '&new_opp->clock_latency_ns' to
> 'of_property_read_u32()' 64 vs 32.
> 
> This code will break on 64 bit, big endian machines.
> 
> Fix this by reading the value in a u32 type variable first and then
> assigning it to the unsigned long variable.
> 
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Suggested-by: Stephen Boyd <sboyd@...eaurora.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>

I've applied this and the [1/2], thanks!

Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/