linux-kernel - Re: [PATCH v2 5/5] [media] c8sectpfe: Update DT binding doc with some minor fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 28 Aug 2015 18:25:59 +0100
From:	Peter Griffin <peter.griffin@...aro.org>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	maxime.coquelin@...com, srinivas.kandagatla@...il.com,
	patrice.chotard@...com, mchehab@....samsung.com,
	devicetree@...r.kernel.org, linux-media@...r.kernel.org
Subject: Re: [PATCH v2 5/5] [media] c8sectpfe: Update DT binding doc with
 some minor fixes

Hi Lee,

On Fri, 28 Aug 2015, Lee Jones wrote:

> On Thu, 27 Aug 2015, Peter Griffin wrote:
> 
> > Signed-off-by: Peter Griffin <peter.griffin@...aro.org>
> > ---
> >  .../devicetree/bindings/media/stih407-c8sectpfe.txt      | 16 +++++++---------
> >  1 file changed, 7 insertions(+), 9 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt b/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
> > index e70d840..5d6438c 100644
> > --- a/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
> > +++ b/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
> > @@ -55,21 +55,20 @@ Example:
> >  		status = "okay";
> >  		reg = <0x08a20000 0x10000>, <0x08a00000 0x4000>;
> >  		reg-names = "stfe", "stfe-ram";
> > -		interrupts = <0 34 0>, <0 35 0>;
> > +		interrupts = <GIC_SPI 34 IRQ_TYPE_NONE>, <GIC_SPI 35 IRQ_TYPE_NONE>;
> >  		interrupt-names = "stfe-error-irq", "stfe-idle-irq";
> > -
> > -		pinctrl-names	= "tsin0-serial", "tsin0-parallel", "tsin3-serial",
> > -				"tsin4-serial", "tsin5-serial";
> > -
> > +		pinctrl-names	= "tsin0-serial",
> > +				  "tsin0-parallel",
> > +				  "tsin3-serial",
> > +				  "tsin4-serial",
> > +				  "tsin5-serial";
> >  		pinctrl-0	= <&pinctrl_tsin0_serial>;
> >  		pinctrl-1	= <&pinctrl_tsin0_parallel>;
> >  		pinctrl-2	= <&pinctrl_tsin3_serial>;
> >  		pinctrl-3	= <&pinctrl_tsin4_serial_alt3>;
> >  		pinctrl-4	= <&pinctrl_tsin5_serial_alt1>;
> > -
> >  		clocks = <&clk_s_c0_flexgen CLK_PROC_STFE>;
> > -		clock-names = "stfe";
> > -
> > +		clock-names = "c8sectpfe";
> 
> Are you sure you even need this property?  I'm thinking that *-names
> properties are *usually* only required if there are more than one in a
> single property.

Yes that is true, but for tsout and merged input stream
functionality the driver will require additional clocks. As I
mentioned in a previous email I hope to add support for this in the
near future.

> 
> >  		/* tsin0 is TSA on NIMA */
> >  		tsin0: port@0 {
> >  			tsin-num		= <0>;
> > @@ -78,7 +77,6 @@ Example:
> >  			reset-gpios		= <&pio15 4 GPIO_ACTIVE_HIGH>;
> >  			dvb-card		= <STV0367_TDA18212_NIMA_1>;
> >  		};
> > -
> 
> My personal preference is to have a '\n' between nodes.

Yes mine as well, I removed it due to your earlier comment about "superflous \n".
I will add it back in again in v3.

> 
> >  		tsin3: port@3 {
> >  			tsin-num		= <3>;
> >  			serial-not-parallel;
> 
> But these comments are pretty trivial, so agree or not, or fix-up or
> not, it's that big of a deal.

I agree all trivial, but will fixup in v3.
> 
> Either way,
>   Acked-by: Lee Jones <lee.jones@...aro.org>

Thanks & regards,

Peter.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/