lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 28 Aug 2015 10:50:50 -0700 From: Darren Hart <dvhart@...radead.org> To: Henrique de Moraes Holschuh <hmh@....eng.br> Cc: Joe Perches <joe@...ches.com>, ibm-acpi-devel@...ts.sourceforge.net, platform-driver-x86@...r.kernel.org, linux-kernel <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] thinkpad_acpi: Remove side effects from vdbg_printk -> no_printk macro On Thu, Aug 27, 2015 at 02:33:06PM -0300, Henrique de Moraes Holschuh wrote: > On Wed, 26 Aug 2015, Joe Perches wrote: > > vdbg_printk when not using CONFIG_THINKPAD_ACPI_DEBUG uses > > no_printk which produces no logging output but always > > evaluates arguments. > > > > Change the macro to surround the no_printk call with > > do { if (0) no_printk(...); } while (0) > > to avoid the unnecessary argument evaluations. > > > > $ size drivers/platform/x86/thinkpad_acpi.o* > > text data bss dec hex filename > > 60918 6184 824 67926 10956 drivers/platform/x86/thinkpad_acpi.o.new > > 60927 6184 824 67935 1095f drivers/platform/x86/thinkpad_acpi.o.old > > > > Signed-off-by: Joe Perches <joe@...ches.com> > > Acked-by: Henrique de Moraes Holschuh <hmh@....eng.br> Queued, thanks. -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists