linux-kernel - Re: [PATCH 0/2] mpt3sas: Reference counting fixes from in-flight mpt2sas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1440793538.2202.55.camel@HansenPartnership.com>
Date:	Fri, 28 Aug 2015 13:25:38 -0700
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
Cc:	Sreekanth Reddy <sreekanth.reddy@...gotech.com>,
	Calvin Owens <calvinowens@...com>,
	"Nicholas A. Bellinger" <nab@...erainc.com>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@...radead.org>,
	"MPT-FusionLinux.pdl" <MPT-FusionLinux.pdl@...gotech.com>,
	kernel-team@...com
Subject: Re: [PATCH 0/2] mpt3sas: Reference counting fixes from in-flight
 mpt2sas

On Thu, 2015-08-27 at 12:15 -0700, Nicholas A. Bellinger wrote:
> On Thu, 2015-08-27 at 07:40 -0700, James Bottomley wrote:
> > On Thu, 2015-08-27 at 10:37 +0530, Sreekanth Reddy wrote:
> > > HI Nicholas & Calvin,
> > > 
> > > Thanks for the patchset. Sure We will review and we do some unit
> > > testing on this patch series. Currently my bandwidth is occupied with
> > > some internal activity, so by end of next week I will acknowledge this
> > > series if all the thing are fine with this patch series.
> > 
> > Calvin responded to your review feedback and that series has been
> > outstanding for a while, so I'm not going to drop it from the misc tree.
> > However, I will reorder to make it ready for the second push. You have
> > until Friday week to find a problem with it.
> > 
> 
> James, as mentioned this series is functionally identical to Calvin's
> mpt2sas series.
> 
> Please consider merging it to scsi.git/for-next, so both series are
> together and in-sync.

Unfortunately, the driver isn't, thanks to drift between v2 and v3 of
the mpt_sas code bases.  This patch is also dangerous: the early
versions left unremoved objects lying around, so  getting some stress
testing from avago is very useful.  At this point in the cycle, the risk
vs reward of doing a blind upport to mpt3_sas is just too great and the
time for review and stress testing too limited within the merge window.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/