linux-kernel - Re: [PATCH] spmi: pmic-arb: Don't byte swap when reading/writing FIFO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150828200106.GU13472@usrtlx11787.corpusers.net>
Date:	Fri, 28 Aug 2015 13:01:06 -0700
From:	Bjorn Andersson <bjorn.andersson@...ymobile.com>
To:	Stephen Boyd <sboyd@...eaurora.org>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	Andy Gross <agross@...eaurora.org>
Subject: Re: [PATCH] spmi: pmic-arb: Don't byte swap when reading/writing FIFO

On Fri 28 Aug 12:21 PDT 2015, Stephen Boyd wrote:

> We don't want to swap bytes that we're reading and writing to the
> FIFOs when we're running on a big-endian CPU. Doing so causes
> problems like where the qcom-spmi-iadc driver can't detect the
> type of device because the bytes are all mixed up. Use the raw IO
> accessors for these API instead, and collapse pmic_arb_base_read()
> into the byte reading API so that we aren't tempted to read non-FIFO
> data like commands with that function.
> 
> Cc: Andy Gross <agross@...eaurora.org>

Acked-by: Bjorn Andersson <bjorn.andersson@...ymobile.com>

Regards,
Bjorn

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/