linux-kernel - Re: [PATCH 2/6] input: pwm-beeper: Fix module autoload for OF platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 28 Aug 2015 17:00:42 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Luis de Bethencourt <luis@...ethencourt.com>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Jingoo Han <jg1.han@...sung.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Olivier Sobrie <olivier@...rie.be>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	Javier Martinez Canillas <javier@....samsung.com>
Subject: Re: [PATCH 2/6] input: pwm-beeper: Fix module autoload for OF
 platform driver

Hi Luis,

On Thu, Aug 27, 2015 at 9:59 AM, Luis de Bethencourt
<luis@...ethencourt.com> wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luis@...ethencourt.com>
> ---
>  drivers/input/misc/pwm-beeper.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
> index e82edf8..a02b9a4 100644
> --- a/drivers/input/misc/pwm-beeper.c
> +++ b/drivers/input/misc/pwm-beeper.c
> @@ -175,6 +175,8 @@ static const struct of_device_id pwm_beeper_match[] = {
>  };
>  #endif
>
> +MODULE_DEVICE_TABLE(of, pwm_beeper_match);
> +

I'm fairly certain this (ano others) blow up in case of !CONFIG_OF.
Please bring MODULE_DEVICE_TABLE into #ifdef block above.

>  static struct platform_driver pwm_beeper_driver = {
>         .probe  = pwm_beeper_probe,
>         .remove = pwm_beeper_remove,
> --
> 2.4.6
>

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/