[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.1508301312250.29683@axis700.grange>
Date: Sun, 30 Aug 2015 13:14:43 +0200 (CEST)
From: Guennadi Liakhovetski <g.liakhovetski@....de>
To: Robert Jarzmik <robert.jarzmik@...e.fr>
cc: Mauro Carvalho Chehab <mchehab@....samsung.com>,
Jiri Kosina <trivial@...nel.org>, linux-media@...r.kernel.org,
linux-kernel@...r.kernel.org,
Robert Jarzmik <robert.jarzmik@...el.com>
Subject: Re: [PATCH v3 3/4] media: pxa_camera: trivial move of dma irq
functions
On Wed, 29 Jul 2015, Robert Jarzmik wrote:
> From: Robert Jarzmik <robert.jarzmik@...el.com>
>
> This moves the dma irq handling functions up in the source file, so that
> they are available before DMA preparation functions. It prepares the
> conversion to DMA engine, where the descriptors are populated with these
> functions as callbacks.
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@...el.com>
> ---
> Since v1: fixed prototypes change
> ---
> drivers/media/platform/soc_camera/pxa_camera.c | 42 +++++++++++++++-----------
> 1 file changed, 24 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/media/platform/soc_camera/pxa_camera.c b/drivers/media/platform/soc_camera/pxa_camera.c
> index 39c7e7519b3c..cdfb93aaee43 100644
> --- a/drivers/media/platform/soc_camera/pxa_camera.c
> +++ b/drivers/media/platform/soc_camera/pxa_camera.c
> @@ -313,6 +313,30 @@ static int calculate_dma_sglen(struct scatterlist *sglist, int sglen,
[snip]
> + pxa_camera_dma_irq(pcdev, DMA_Y);
[snip]
> - pxa_camera_dma_irq(channel, pcdev, DMA_Y);
This still seems to break compilation to me. Could you compile-test after
each your patch, please?
Thanks
Guennadi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists