lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 31 Aug 2015 13:19:40 +0200 From: Jiri Olsa <jolsa@...hat.com> To: Kan Liang <kan.liang@...el.com> Cc: acme@...nel.org, jolsa@...nel.org, a.p.zijlstra@...llo.nl, luto@...nel.org, mingo@...hat.com, eranian@...gle.com, ak@...ux.intel.com, mark.rutland@....com, adrian.hunter@...el.com, namhyung@...nel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH V7 6/8] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY% in report -D On Fri, Aug 28, 2015 at 05:48:07AM -0400, Kan Liang wrote: SNIP > > static struct machine *machines__find_for_cpumode(struct machines *machines, > @@ -1079,11 +1101,12 @@ static int machines__deliver_event(struct machines *machines, > > switch (event->header.type) { > case PERF_RECORD_SAMPLE: > - dump_sample(evsel, event, sample); > if (evsel == NULL) { > ++evlist->stats.nr_unknown_id; > return 0; > } > + dump_sample(evsel, event, sample); > + could you submit this hunk separately.. seems like we could segfault in dump_sample if there's evsel == NULL, right? jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists