lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 31 Aug 2015 10:54:51 -0300 From: Arnaldo Carvalho de Melo <acme@...hat.com> To: Wang Nan <wangnan0@...wei.com> Cc: linux-kernel@...r.kernel.org, lizefan@...wei.com, pi3orama@....com, Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>, Arnaldo Carvalho de Melo <acme@...nel.org> Subject: Re: [PATCH] perf tools: Fix cross compiling error Em Fri, Aug 28, 2015 at 12:54:02PM +0000, Wang Nan escreveu: > Cross compiling perf to other platform failed due to missing symbol: > > ... > AR /pathofperf/libperf.a > LD /pathofperf/tests/perf-in.o > LD /pathofperf/perf-in.o > LINK /pathofperf/perf > /pathofperf/libperf.a(libperf-in.o): In function `intel_pt_synth_branch_sample': > /usr/src/kernel/tools/perf/util/intel-pt.c:899: undefined reference to `tsc_to_perf_time' > /pathofperf/libperf.a(libperf-in.o): In function `intel_pt_synth_transaction_sample': > /usr/src/kernel/tools/perf/util/intel-pt.c:992: undefined reference to `tsc_to_perf_time' > /pathofperf/libperf.a(libperf-in.o): In function `intel_pt_synth_instruction_sample': > /usr/src/kernel/tools/perf/util/intel-pt.c:943: undefined reference to `tsc_to_perf_time' > ... > > This is because we allow newly introduced intel-pt-decoder to be > compiled to not only X86, but tsc.c which required by it is compiled > for x86 only. > > This patch fix the compiling error by allow tsc.c to be compiled if > CONFIG_AUXTRACE is set, no matter the target platform. There were some changes in this area, i.e. x86 needs tsc, and auxtrace as well, so both should express that via: libperf-$(CONFIG_X86) += tsc.o libperf-$(CONFIG_AUXTRACE) += tsc.o Because on !x86 we want to process perf.data files containing Intel PT. Adding Jiri and Adrian to the CC list. - Arnaldo > Signed-off-by: Wang Nan <wangnan0@...wei.com> > Cc: Arnaldo Carvalho de Melo <acme@...hat.com> > --- > tools/perf/util/Build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/Build b/tools/perf/util/Build > index fd2f084..c8d9c7e 100644 > --- a/tools/perf/util/Build > +++ b/tools/perf/util/Build > @@ -74,7 +74,7 @@ libperf-y += stat-shadow.o > libperf-y += record.o > libperf-y += srcline.o > libperf-y += data.o > -libperf-$(CONFIG_X86) += tsc.o > +libperf-$(CONFIG_AUXTRACE) += tsc.o > libperf-y += cloexec.o > libperf-y += thread-stack.o > libperf-$(CONFIG_AUXTRACE) += auxtrace.o > -- > 1.8.3.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists