lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 31 Aug 2015 08:01:58 -0600
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	"K. Y. Srinivasan" <kys@...rosoft.com>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org, ohering@...e.com,
	jbottomley@...allels.com, hch@...radead.org,
	linux-scsi@...r.kernel.org, apw@...onical.com, vkuznets@...hat.com,
	jasowang@...hat.com, stable@...r.kernel.org
Subject: Re: [PATCH 1/1] storvsc: Don't set the
 SRB_FLAGS_QUEUE_ACTION_ENABLE flag

On Mon, 2015-08-31 at 08:21 -0700, K. Y. Srinivasan wrote:
> Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag since we are not specifying
> tags.

What's the actual problem description this causes?

James


> Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> Cc: stable@...r.kernel.org
> ---
>  drivers/scsi/storvsc_drv.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 40c43ae..ad8c4bc 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1647,8 +1647,7 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd)
>  	vm_srb->win8_extension.time_out_value = 60;
>  
>  	vm_srb->win8_extension.srb_flags |=
> -		(SRB_FLAGS_QUEUE_ACTION_ENABLE |
> -		SRB_FLAGS_DISABLE_SYNCH_TRANSFER);
> +		SRB_FLAGS_DISABLE_SYNCH_TRANSFER;
>  
>  	/* Build the SRB */
>  	switch (scmnd->sc_data_direction) {



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists