[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150831111304.3888a8f6@gandalf.local.home>
Date: Mon, 31 Aug 2015 11:13:04 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Vlastimil Babka <vbabka@...e.cz>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org, linux-mm@...ck.org,
Joonsoo Kim <iamjoonsoo.kim@....com>,
Ingo Molnar <mingo@...hat.com>, Mel Gorman <mgorman@...e.de>,
David Rientjes <rientjes@...gle.com>
Subject: Re: [PATCH 2/3] mm, compaction: export tracepoints zone names to
userspace
On Mon, 31 Aug 2015 17:02:38 +0200
Vlastimil Babka <vbabka@...e.cz> wrote:
> >> +#define ZONE_TYPE \
> >> + IFDEF_ZONE_DMA( EM (ZONE_DMA, "DMA")) \
> >> + IFDEF_ZONE_DMA32( EM (ZONE_DMA32, "DMA32")) \
> >> + EM (ZONE_NORMAL, "Normal") \
> >> + IFDEF_ZONE_HIGHMEM( EM (ZONE_HIGHMEM,"HighMem")) \
> >> + EMe(ZONE_MOVABLE,"Movable")
> >> +
> >
> > Hmm, have you tried to compile this with CONFIG_ZONE_HIGHMEM disabled,
> > and CONFIG_ZONE_DMA and/or CONFIG_ZONE_DMA32 enabled?
>
> Yep, that's standard x86_64 situation (highmem disabled, dma+dma32 enabled).
>
> > The EMe() macro must come last, as it doesn't have the ending comma and
> > the __print_symbolic() can fail to compile due to it.
>
> Thanks to ZONE_MOVABLE being unconditional, EMe(ZONE_MOVABLE...) is
> always last. Otherwise the macros would get even more ugly...
Ah! My mistake was to see where the end parenthesis of
IFDEF_ZONE_HIGHMEM() laid. It looked to me that it encompassed
ZONE_MOVABLE. But obviously it does not.
-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists