linux-kernel - Re: [RFC v6 10/40] richacl: Permission check algorithm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150831152304.GE17812@fieldses.org>
Date:	Mon, 31 Aug 2015 11:23:04 -0400
From:	"J. Bruce Fields" <bfields@...ldses.org>
To:	Andreas Grünbacher 
	<andreas.gruenbacher@...il.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux FS-devel Mailing List <linux-fsdevel@...r.kernel.org>,
	Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
	Linux API Mailing List <linux-api@...r.kernel.org>,
	linux-cifs@...r.kernel.org,
	LSM List <linux-security-module@...r.kernel.org>,
	Andreas Gruenbacher <agruenba@...hat.com>
Subject: Re: [RFC v6 10/40] richacl: Permission check algorithm

On Sat, Aug 29, 2015 at 12:06:22AM +0200, Andreas Grünbacher wrote:
> 2015-08-28 23:49 GMT+02:00 J. Bruce Fields <bfields@...ldses.org>:
> > On Tue, Aug 04, 2015 at 01:53:08PM +0200, Andreas Gruenbacher wrote:
> >> +             /*
> >> +              * We don't care which class the process is in when the acl is
> >> +              * not masked.
> >> +              */
> >> +             in_owner_or_group_class = 1;
> >
> > So why bother setting it at all, then?  Oh, I see, it lets you break out
> > of the loop below earlier.  OK.
> 
> Comment changed to:
> 
>                 /*
>                  * When the acl is not masked, there is no need to determine if
>                  * the process is in the group class and we can earlier break
>                  * out of the loop below.
>                  */

makes sense, just replace "earlier break out" by "break out earlier".

> 
> > Patch makes sense to me, ACK.
> 
> Thanks,
> Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/