[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150831113257.54d7ca4b@gandalf.local.home>
Date: Mon, 31 Aug 2015 11:32:57 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Vlastimil Babka <vbabka@...e.cz>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org, linux-mm@...ck.org,
Joonsoo Kim <iamjoonsoo.kim@....com>,
Ingo Molnar <mingo@...hat.com>, Mel Gorman <mgorman@...e.de>,
David Rientjes <rientjes@...gle.com>
Subject: Re: [PATCH 2/3] mm, compaction: export tracepoints zone names to
userspace
On Thu, 27 Aug 2015 17:24:03 +0200
Vlastimil Babka <vbabka@...e.cz> wrote:
> Some compaction tracepoints use zone->name to print which zone is being
> compacted. This works for in-kernel printing, but not userspace trace printing
> of raw captured trace such as via trace-cmd report.
>
> This patch uses zone_idx() instead of zone->name as the raw value, and when
> printing, converts the zone_type to string using the appropriate EM() macros
> and some ugly tricks to overcome the problem that half the values depend on
> CONFIG_ options and one does not simply use #ifdef inside of #define.
>
> trace-cmd output before:
> transhuge-stres-4235 [000] 453.149280: mm_compaction_finished: node=0
> zone=ffffffff81815d7a order=9 ret=partial
>
> after:
> transhuge-stres-4235 [000] 453.149280: mm_compaction_finished: node=0
> zone=Normal order=9 ret=partial
>
> Signed-off-by: Vlastimil Babka <vbabka@...e.cz>
> Cc: Joonsoo Kim <iamjoonsoo.kim@....com>
> Cc: Steven Rostedt <rostedt@...dmis.org>
Reviewed-by: Steven Rostedt <rostedt@...dmis.org>
-- Steve
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Mel Gorman <mgorman@...e.de>
> Cc: David Rientjes <rientjes@...gle.com>
> ---
> include/trace/events/compaction.h | 38 ++++++++++++++++++++++++++++++++------
> 1 file changed, 32 insertions(+), 6 deletions(-)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists