linux-kernel - Re: [PATCH] reset: Add (devm_)reset_control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1441036886.3234.50.camel@pengutronix.de>
Date:	Mon, 31 Aug 2015 18:01:26 +0200
From:	Philipp Zabel <p.zabel@...gutronix.de>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
	Arnaud Pouliquen <arnaud.pouliquen@...com>,
	Liam Girdwood <lgirdwood@...il.com>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] reset: Add (devm_)reset_control_get stub functions

Hi Axel,

thank you for the patch.

Am Montag, den 31.08.2015, 17:22 +0800 schrieb Axel Lin:
> So the drivers can be compiled with CONFIG_RESET_CONTROLLER disabled.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>  include/linux/reset.h | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/include/linux/reset.h b/include/linux/reset.h
> index da5602b..cd42c1b 100644
> --- a/include/linux/reset.h
> +++ b/include/linux/reset.h
> @@ -74,6 +74,18 @@ static inline int device_reset_optional(struct device *dev)
>  	return -ENOSYS;
>  }
>  
> +static inline struct reset_control *reset_control_get(
> +					struct device *dev, const char *id)
> +{
> +	return ERR_PTR(-ENOSYS);
> +}
> +
> +static inline struct reset_control *devm_reset_control_get(
> +					struct device *dev, const char *id)
> +{
> +	return ERR_PTR(-ENOSYS);
> +}
> +

Could you add a WARN_ON(1) to both, make them __must_check, and return
something other than -ENOSYS. For example the gpio stubs return -EINVAL.

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/