linux-kernel - Re: [PATCH v2 4/4] perf script: enable printing of branch stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150831170535.GY4524@tassilo.jf.intel.com>
Date:	Mon, 31 Aug 2015 10:05:35 -0700
From:	Andi Kleen <ak@...ux.intel.com>
To:	Stephane Eranian <eranian@...gle.com>
Cc:	linux-kernel@...r.kernel.org, acme@...hat.com,
	peterz@...radead.org, mingo@...e.hu, jolsa@...hat.com,
	namhyung@...nel.org, kan.liang@...el.com, dsahern@...il.com,
	adrian.hunter@...el.com
Subject: Re: [PATCH v2 4/4] perf script: enable printing of branch stack

>  $ perf script -F ip,brstack
>   5d3000 0x401aa0/0x5d2000/M/-/-/-/0 ...
> 
>  $ perf script -F ip,brstacksym
>   4011e0 noploop+0x0/noploop+0x0/P/-/-/0

That's a weird format that's hard to parse with standard tools like
awk, and also for humans. How about separating with spaces?

> @@ -175,6 +175,16 @@ OPTIONS
>  	Finally, a user may not set fields to none for all event types.
>  	i.e., -f "" is not allowed.
>  
> +	The brstack output includes branch related information with raw addresses using the
> +	/v/v/v/v/ syntax in the following order:
> +	FROM: branch source instruction
> +	TO  : branch target instruction
> +        M/P/-: M=branch target mispredicted or branch direction was mispredicted, P=target predicted or direction predicted, -=not supported
> +	X/- : X=branch inside a transactional region, -=not in transaction region or not supported
> +	A/- : A=TSX abort entry, -=not aborted region or not supported

Need to describe cycles here too.

The rest looks good to me. Should probably add brstacksrcline too, but that
can be done later.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/