linux-kernel - Re: [GIT PULL] bcache revert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55E4A77F.7030802@fb.com>
Date:	Mon, 31 Aug 2015 13:14:07 -0600
From:	Jens Axboe <axboe@...com>
To:	Kent Overstreet <kent.overstreet@...il.com>,
	<torvalds@...ux-foundation.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] bcache revert

On 08/31/2015 01:00 PM, Kent Overstreet wrote:
> Linus, please pull; this reverts a patch from Jens that was committed without
> CCing be or being mailed out to any of the lists. Said patch wasn't in any way a
> functional change and is something that damn well should have been discussed.
>
> Jens - what the goddamn fuck!? You've never touched the bcache code until now,
> and when you finally get interested this is what you do!?
>
> While I am sympathetic to the arguments in favor of your patch, there _are_ some
> damn good reasons I did it the way I did. If you want to have that discussion,
> feel free to mail your patch out again after the revert.

The patch was part of a larger series that I was working on, and I just 
wanted to flush out that dependency. Christoph review and acked it, it 
was by no means a sneaking in of a patch.

So calm down. Is there a bug? The previous code was crap, having hidden 
returns in macros is horrible. The upstream bcache code has been 
effectively unmaintained for more than a year, and THIS patch is now a 
problem? Get real.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/