linux-kernel - Re: [PATCH net-next] lib: move strncpy_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55E4AE5A.7010003@roeck-us.net>
Date:	Mon, 31 Aug 2015 12:43:22 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	David Miller <davem@...emloft.net>, ast@...mgrid.com
CC:	fengguang.wu@...el.com, rostedt@...dmis.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] lib: move strncpy_from_unsafe() into mm/maccess.c

On 08/31/2015 12:36 PM, David Miller wrote:
> From: Alexei Starovoitov <ast@...mgrid.com>
> Date: Mon, 31 Aug 2015 08:57:10 -0700
>
>> To fix build errors:
>> kernel/built-in.o: In function `bpf_trace_printk':
>> bpf_trace.c:(.text+0x11a254): undefined reference to `strncpy_from_unsafe'
>> kernel/built-in.o: In function `fetch_memory_string':
>> trace_kprobe.c:(.text+0x11acf8): undefined reference to `strncpy_from_unsafe'
>>
>> move strncpy_from_unsafe() next to probe_kernel_read/write()
>> which use the same memory access style.
>>
>> Reported-by: Fengguang Wu <fengguang.wu@...el.com>
>> Reported-by: Guenter Roeck <linux@...ck-us.net>

Too late, but:

Tested-by: Guenter Roeck <linux@...ck-us.net>

Guenter

>> Fixes: 1a6877b9c0c2 ("lib: introduce strncpy_from_unsafe()")
>> Signed-off-by: Alexei Starovoitov <ast@...mgrid.com>
>> ---
>> For configs without kprobes and bpf the cost of this unused function is
>> ~200 bytes which I think is a better trade off vs creating
>> new Kconfig selector just for this single function.
>> Another alternative is to move it to kernel/trace/trace_kprobe.c,
>> but then it will lose generality and probably should be removed
>> from include/linux/uaccess.h, so mm/maccess.c looks the best.
>
> Ok, applied.
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/